Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for update #1150

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Add tests for update #1150

merged 3 commits into from
Nov 23, 2022

Conversation

anniel-stripe
Copy link
Contributor

Summary

(Follow up to #1149)

Add .update tests in addition to .save, as .save is deprecated in favor of .update.

richardm-stripe
richardm-stripe approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the tests look good.

All the tests that begin with
```Stripe::Account.construct_from(...)don't make a whole lot of sense to me, because::update` doesn't really interact with the constructed object at all.

richardm-stripe
richardm-stripe suggested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, meant to Request Changes.

anniel-stripe and others added 2 commits November 21, 2022 17:32
@anniel-stripe anniel-stripe merged commit a96e6f3 into master Nov 23, 2022
@anniel-stripe anniel-stripe deleted the anniel-add-update-tests branch November 23, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardm-stripe richardm-stripe richardm-stripe approved these changes

Assignees

@richardm-stripe richardm-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anniel-stripe @richardm-stripe